Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix 9607 Pass Credentials to Get-DbaDbUdf from Set-DbaResourceGovernor #9609

Open
wants to merge 3 commits into
base: development
Choose a base branch
from
Open

Bugfix 9607 Pass Credentials to Get-DbaDbUdf from Set-DbaResourceGovernor #9609

wants to merge 3 commits into from

Conversation

darrenmaginnis
Copy link

@darrenmaginnis darrenmaginnis commented Feb 28, 2025 •
edited
Loading

Type of Change

  • Bug fix (non-breaking change, fixes Set-DbaResourceGovernor does not pass $SqlCredential to called Get-DbaDbUdf command #9607 )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (affects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (Invoke-ManualPester)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

Purpose

Quick fix passing SqlCredential to Get-DbaDbUdf from Set-DbaResourceGovernor

Approach

Allows Get-DbaDbUdf to authorise to the sql server

Commands to test

Set-DbaResourceGovernor -SqlInstance $ComputerName -SqlCredential $SqlSysAdmin -Enabled -ClassifierFunction "WorkloadClassifier"

@darrenmaginnis darrenmaginnis changed the title Bugfix 9607 Pass SqlCredential to Get-DbaDbUdf from Set-DbaResourceGovernor Bugfix 9607 Pass Credentials to Get-DbaDbUdf from Set-DbaResourceGovernor Feb 28, 2025
@darrenmaginnis
Revert "Bugfix 9607 Useing the DbaInstance variable instead"
9613fe4 
that didn't work as expected, going back to passing in the Credentials

This reverts commit 4d534c7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set-DbaResourceGovernor does not pass $SqlCredential to called Get-DbaDbUdf command
1 participant
@darrenmaginnis